[OpenLayers-Commits] r6036 - trunk/openlayers/lib/OpenLayers/Format

[commits at openlayers.org]

Author: crschmidt
Date: 2008-02-07 16:54:33 -0500 (Thu, 07 Feb 2008)
New Revision: 6036

Modified:
   trunk/openlayers/lib/OpenLayers/Format/WFS.js
Log:
Refactor out names into namespace prefixes for overridability (and to make 
the  code slightly less verbose).


Modified: trunk/openlayers/lib/OpenLayers/Format/WFS.js
===================================================================
--- trunk/openlayers/lib/OpenLayers/Format/WFS.js	2008-02-07 21:42:11 UTC (rev 6035)
+++ trunk/openlayers/lib/OpenLayers/Format/WFS.js	2008-02-07 21:54:33 UTC (rev 6036)
@@ -22,6 +22,8 @@
      */
     wfsns: "http://www.opengis.net/wfs",
     
+    ogcns: "http://www.opengis.net/ogc",
+    
     /*
      * Constructor: OpenLayers.Format.WFS
      * Create a WFS-T formatter. This requires a layer: that layer should
@@ -57,8 +59,8 @@
      * features - {Array(<OpenLayers.Feature.Vector>)} 
      */
     write: function(features) {
-        
-        var transaction = this.createElementNS('http://www.opengis.net/wfs', 'wfs:Transaction');
+    
+        var transaction = this.createElementNS(this.wfsns, 'wfs:Transaction');
         transaction.setAttribute("version","1.0.0");
         transaction.setAttribute("service","WFS");
         for (var i=0; i < features.length; i++) {
@@ -128,20 +130,20 @@
         updateNode.setAttribute("typeName", this.layerName);
 
         var propertyNode = this.createElementNS(this.wfsns, 'wfs:Property');
-        var nameNode = this.createElementNS('http://www.opengis.net/wfs', 'wfs:Name');
+        var nameNode = this.createElementNS(this.wfsns, 'wfs:Name');
         
         var txtNode = document.createTextNode(this.geometryName);
         nameNode.appendChild(txtNode);
         propertyNode.appendChild(nameNode);
         
-        var valueNode = this.createElementNS('http://www.opengis.net/wfs', 'wfs:Value');
+        var valueNode = this.createElementNS(this.wfsns, 'wfs:Value');
         valueNode.appendChild(this.buildGeometryNode(feature.geometry));
         
         propertyNode.appendChild(valueNode);
         updateNode.appendChild(propertyNode);
         
-        var filterNode = this.createElementNS('http://www.opengis.net/ogc', 'ogc:Filter');
-        var filterIdNode = this.createElementNS('http://www.opengis.net/ogc', 'ogc:FeatureId');
+        var filterNode = this.createElementNS(this.ogcns, 'ogc:Filter');
+        var filterIdNode = this.createElementNS(this.ogcns, 'ogc:FeatureId');
         filterIdNode.setAttribute("fid", feature.fid);
         filterNode.appendChild(filterIdNode);
         updateNode.appendChild(filterNode);
@@ -164,8 +166,8 @@
         var deleteNode = this.createElementNS(this.featureNS, 'wfs:Delete');
         deleteNode.setAttribute("typeName", this.layerName);
 
-        var filterNode = this.createElementNS('http://www.opengis.net/ogc', 'ogc:Filter');
-        var filterIdNode = this.createElementNS('http://www.opengis.net/ogc', 'ogc:FeatureId');
+        var filterNode = this.createElementNS(this.ogcns, 'ogc:Filter');
+        var filterIdNode = this.createElementNS(this.ogcns, 'ogc:FeatureId');
         filterIdNode.setAttribute("fid", feature.fid);
         filterNode.appendChild(filterIdNode);
         deleteNode.appendChild(filterNode);