[OpenLayers-Trac] [OpenLayers] #716: Make LayerSwitcher support displayInLayerSwitcher for Base Layers

OpenLayers trac at openlayers.org
Fri Aug 3 15:53:04 EDT 2007


#716: Make LayerSwitcher support displayInLayerSwitcher for Base Layers
------------------------------------+---------------------------------------
  Reporter:  openlayers             |       Owner:  euzuro     
      Type:  feature                |      Status:  new        
  Priority:  minor                  |   Milestone:  2.5 Release
 Component:  Control.LayerSwitcher  |     Version:  2.4 RC3    
Resolution:                         |    Keywords:  review     
------------------------------------+---------------------------------------
Comment (by euzuro):

 no time for full review, but this:

 1)

 {{{
     if (!baseLayer) {
         containsOverlays = true;
     } else {
         containsBaseLayers = true;
     }
 }}}

 should be (for readability)

 {{{
     if (baseLayer) {
         containsBaseLayers = true;
     } else {
         containsOverlays = true;
     }
 }}}

 2) copy/paste error in the comment here:

 {{{
         265             // if no overlays, dont display the overlay label
         266             this.baseLbl.style.display = (containsBaseLayers)
 ? "" : "none";
 }}}

 should be

 {{{
         265             // if no baselayers, dont display the baselayer
 label
         266             this.baseLbl.style.display = (containsBaseLayers)
 ? "" : "none";
 }}}

-- 
Ticket URL: <http://trac.openlayers.org/ticket/716#comment:3>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list