[OpenLayers-Trac] [OpenLayers] #895: Better behaviour of Panel.js

[OpenLayers]

#895: Better behaviour of Panel.js
----------------------+-----------------------------------------------------
  Reporter:  jachym   |       Owner:             
      Type:  bug      |      Status:  new        
  Priority:  minor    |   Milestone:  2.6 Release
 Component:  general  |     Version:  SVN        
Resolution:           |    Keywords:             
----------------------+-----------------------------------------------------
Changes (by crschmidt):

  * keywords:  review =>

Comment:

 Button types are instant-fire actions. They are meant to be used for
 things like zoomToMaxExtent. The Button Control implements this, as does
 the canonical Control example, zoomToMaxExtent.

 The default type of control (Tool) is meant to be a radio-button style
 control: this means that you are not meant to be able to turn it 'off': If
 that functionality is desired, I think it deserves a seperate ticket,
 since probably more than just the Control.Panel needs to be aware of that.

 The last fix -- lack of redrawing for toggle controls -- is definitely a
 valid fix, and was only not noticed for so long because we don't have any
 toggle controls yet. However, in order to confirm that this continues to
 work -- since we don't yet have anything that would actually show it *not*
 working -- can we please have a test? It should be pretty simple:

 c = new OpenLayers.Control.Panel();
 // add some toggle controls here
 c.redraw = function() { t.ok(true, "Redraw called"); }
 c.activate(a_toggle_control);

 Or something similar.

 If we can get that, and an updated patch, it will make sense to put this
 in trunk.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/895#comment:2>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer