[OpenLayers-Trac] [OpenLayers] #1123: OpenLayers.Layer.Markers.destroy() should destroy its markers

OpenLayers trac at openlayers.org
Sun Dec 2 15:26:56 EST 2007


#1123: OpenLayers.Layer.Markers.destroy() should destroy its markers
----------------------------+-----------------------------------------------
  Reporter:  ahocevar       |       Owner:  euzuro     
      Type:  bug            |      Status:  new        
  Priority:  minor          |   Milestone:  2.6 Release
 Component:  Layer.Markers  |     Version:  2.5        
Resolution:                 |    Keywords:  review     
----------------------------+-----------------------------------------------
Comment (by elemoine):

 Replying to [comment:5 crschmidt]:
 > The problem is that the markers internally have a reference to their
 div, which means that the markers themselves aren't garbage collected,
 because references across the DOM/JS line don't get properly cleaned up
 for markers that the user doesn't manually destroy() first.

 ----

 Hmmm I see

 ----

 > However, this does mean (if the email you're talking about is correct)
 that we should apply this to the *text* layer, since the text layer
 actually creates the markers, and therefore should also be destroying
 them. (I'm still not convinced we should be doing it for the markers
 layer.)

 ----

 I was thinking the same: in that case the creator of markers is the text
 layer, so the text layer is responsible for destroying the markers.

 I would agree with Erik: "you create it, you destroy it"

-- 
Ticket URL: <http://trac.openlayers.org/ticket/1123#comment:6>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list