[OpenLayers-Trac] [OpenLayers] #1125: Smoother dragging of the map on older computers

OpenLayers trac at openlayers.org
Tue Nov 6 09:14:51 EST 2007


#1125: Smoother dragging of the map on older computers
----------------------------------+-----------------------------------------
  Reporter:  haakeyar             |       Owner:  tschaub
      Type:  bug                  |      Status:  new    
  Priority:  minor                |   Milestone:         
 Component:  Control.DragFeature  |     Version:  SVN    
Resolution:                       |    Keywords:  review 
----------------------------------+-----------------------------------------
Comment (by haakeyar):

 Using clearTimeout instead of this.updateMapTimeout would neither work nor
 be necessary. Since it happens inside of the timeout, it is already
 cleared (or, at least it won't be called again). And clearTimeout clears
 the timeout with the id in the argument, but the variable that contains
 the timeout id is not cleared (since it is just an integer).

 Btw, about the timeout: The line
 if(!this.updateMapTimeout)
 should maybe be changed to
 if(this.updateMapTimeout == null)
 just in case a timeout would get the id 0. I'll upload a modified versjon
 of the patch. :)

 Which component would you suggest if it should not be in
 Control.DragFeature? As I said, I don't know the code structure very well.
 The reason that I chose Control.DragFeature was that the code was located
 in Control/DragPan.js.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/1125#comment:2>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list