[OpenLayers-Trac] [OpenLayers] #1475: Set the imageSrc before the supper class initialzed in FramedCloud popup

[OpenLayers]

#1475: Set the imageSrc before the supper class initialzed in FramedCloud popup
---------------------+------------------------------------------------------
  Reporter:  avlee   |       Owner:  euzuro     
      Type:  bug     |      Status:  new        
  Priority:  major   |   Milestone:  2.6 Release
 Component:  Popup   |     Version:  SVN        
Resolution:          |    Keywords:             
     State:  Commit  |  
---------------------+------------------------------------------------------
Changes (by ahocevar):

  * state:  Needs More Work => Commit

Comment:

 {{{
         <elemoine>      ahocevar: what value would you give to imageSrc in
 Framed?
         <ahocevar>      elemoine: first, I have to admit that this is the
 first time for me looking into the new popup code.
         <elemoine>      ahocevar: same here ;-)
         <ahocevar>      But the way it is done now would only make sense
 if Popup.Framed is some kind of abstract class, which I don't know if it
 is.
         <elemoine>      I'm wondering if Popup.Framed is something people
 can use or just an abstract class
         <elemoine>      agreed
         <ahocevar>      so let's assume it is an abstract class.
         <ahocevar>      In that case, avlee's patch should at least not do
 any harm.
         <ahocevar>      (in every other case neither, but then something
 else might be wrong)
         <elemoine>      yep
         <elemoine>      it's even a good fix AFAICT
         <elemoine>      right now, imageSrc isn't taken into account when
 the Framed class constructor is called
         <elemoine>      which doesn't look correct
         <ahocevar>      yes. so the patch seems to be good.
         <ahocevar>      I don't see anything wrong about it.
         <elemoine>      me neither
         <elemoine>      I think the patch fixes the case when
 fixedRelativePosition is true (which isn't the default)
         <elemoine>      when fixedRelativePosition is false,
 Framed.createBlocks (which uses imageSrc) isn't called in the constructor
 but when setSize is called}}}
 The patch looks good. Only one thing to mention: If Popup.Framed is not
 supposed to be an abstract class, then something might be wrong there
 (probably unrelated to this ticket).

-- 
Ticket URL: <http://trac.openlayers.org/ticket/1475#comment:3>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer