[OpenLayers-Trac] [OpenLayers] #1308: tween (animation) in OpenLayers

[OpenLayers]

#1308: tween (animation) in OpenLayers
----------------------+-----------------------------------------------------
  Reporter:  pgiraud  |       Owner:             
      Type:  feature  |      Status:  new        
  Priority:  minor    |   Milestone:  2.6 Release
 Component:  general  |     Version:  2.5        
Resolution:           |    Keywords:             
     State:  Review   |  
----------------------+-----------------------------------------------------
Comment (by elemoine):

 Replying to [comment:5 pgiraud]:
 > tests pass under FF
 > almost all tests pass under IE6 : test_OSM doesn't but it doesn't with
 trunk for me either

 Pierre,

 The code looks good to me!

 A few comments:

  * The initialize method doesn't have the usual ND comment indicating that
 it is the constructor.
  * In the tween.html example you may want to call stop() on the previous
 tween object when changing the tween.
  * By the way, still in the tween.html example, why do you need to create
 a new tween object to change the easing? Reading your code, I think your
 could just do {{{tween.easing =  OpenLayers.Easing[transition][easing]}}},
 couldn't you?
  * Even though I think the tween.html example is useful, I'm not sure it
 should be in the examples/ directory. To me the things in examples/ show
 the end-user how to use !OpenLayers. The tween code doesn't belong the
 !OpenLayers API.
  * The functions of the Easing objects are marked APIFunction. Do we
 really want these functions to be part of the !OpenLayers API? (to me: no)

-- 
Ticket URL: <http://trac.openlayers.org/ticket/1308#comment:6>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer