[OpenLayers-Trac] [OpenLayers] #1308: tween (animation) in OpenLayers

[OpenLayers]

#1308: tween (animation) in OpenLayers
----------------------+-----------------------------------------------------
  Reporter:  pgiraud  |       Owner:             
      Type:  feature  |      Status:  new        
  Priority:  minor    |   Milestone:  2.6 Release
 Component:  general  |     Version:  2.5        
Resolution:           |    Keywords:             
     State:  Review   |  
----------------------+-----------------------------------------------------
Comment (by pgiraud):

 Thanks very much for this great review. I think I should have checked the
 code before I set this ticket's state to review.

 >
 >  * The initialize method doesn't have the usual ND comment indicating
 that it is the constructor.
 Ok, and I completed/modified some other ND docs. Some properties are now
 marked as API.

 >  * In the tween.html example you may want to call stop() on the previous
 tween object when changing the tween.
 It looks like it a good choice. I don't think this is really needed.

 >  * By the way, still in the tween.html example, why do you need to
 create a new tween object to change the easing? Reading your code, I think
 your could just do {{{tween.easing =
 OpenLayers.Easing[transition][easing]}}}, couldn't you?
 You seem to be right. Changed.

 >  * Even though I think the tween.html example is useful, I'm not sure it
 should be in the examples/ directory. To me the things in examples/ show
 the end-user how to use !OpenLayers. The tween code doesn't belong the
 !OpenLayers API.
 Agreed. I moved the tween.html example to tests/manual. Do you think this
 is a better idea ?

 >  * The functions of the Easing objects are marked APIFunction. Do we
 really want these functions to be part of the !OpenLayers API? (to me: no)
 I mixed API/ non API with private/public, my bad. Fixed.

 Everything is fixed in the upcoming patch. I think, this is now ready for
 a last review.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/1308#comment:7>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer