[OpenLayers-Trac] [OpenLayers] #1240: navigation history control

OpenLayers trac at openlayers.org
Wed Feb 6 14:53:49 EST 2008


#1240: navigation history control
----------------------+-----------------------------------------------------
  Reporter:  tschaub  |       Owner:  tschaub    
      Type:  feature  |      Status:  assigned   
  Priority:  minor    |   Milestone:  2.6 Release
 Component:  Control  |     Version:  2.5        
Resolution:           |    Keywords:             
     State:  Review   |  
----------------------+-----------------------------------------------------
Comment (by tschaub):

 Replying to [comment:22 pgiraud]:
 > I took a look at your patch yesterday night before I went to sleep.
 > I didn't really take part to the discussion, so I can't really say "ok,
 go and commit".
 > The code looks nice to me though, clear and easy to understand.
 >
 > However, here is one tiny suggestion for your patch. You should probably
 put a "var" in front of lines 8 and 21 in
 tests/Control/test_NavigationHistory.html for the "control" variable.
 >
 > My 2 cents.


 Thanks for taking a look.  I'll correct the control scoping when I commit.
 Though this ticket has many comments, I think the discussion is
 effectively done.  Pipe up if I'm wrong.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/1240#comment:23>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list