[OpenLayers-Trac] [OpenLayers] #1120: users should be able to customize the select style per feature

[OpenLayers]

#1120: users should be able to customize the select style per feature
----------------------+-----------------------------------------------------
  Reporter:  tschaub  |       Owner:             
      Type:  task     |      Status:  new        
  Priority:  minor    |   Milestone:  2.6 Release
 Component:  general  |     Version:  2.5        
Resolution:           |    Keywords:             
     State:  Review   |  
----------------------+-----------------------------------------------------
Comment (by elemoine):

 Thanks for this excellent work Andreas. My review comments below.

 !StyleMap

  * I'd like that the return value of createSymbolizer() be commented

 Layer.Vector

  * Shouldn't styleMap be an API property?

 Feature.Vector

  * Can application code change a feature's renderIntent value before
 calling layer.drawFeature(feature)? If so, shouldn't renderIntent be an
 API property?

 Control.!SelectFeature

  * If application code can indeed change a feature's renderIntent I'm a
 bit concerned with having unselect() use "default" as the render intent.
 Actually, I realize than the renderIntent property of Feature.Vector is
 not an API property, it just reflects the current rendered style of the
 feature. Maybe this could be made more explicit.

 examples/openmnnd.html

  * You changed the value of !OpenLayers.!ProxyHost. Was it on purpose?

 examples/sld.html

  * The waterStyle var is no longer used so it can be removed
  * I played with this example but I guess it's broken: the default
 rendering is not as expected and nothing happens when changing the styler

 examples/select-feature.html

  * I know you haven't modified that file, but I noticed that this example
 is broken: feature selection does no longer change the rendering style

 examples/modify-feature.html

  * Same comment as for the select-feature.html example

-- 
Ticket URL: <http://trac.openlayers.org/ticket/1120#comment:10>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer