[OpenLayers-Trac] [OpenLayers] #1235: ModifyFeature control has problems with its drag handler

OpenLayers trac at openlayers.org
Thu Jan 3 04:47:19 EST 2008


#1235: ModifyFeature control has problems with its drag handler
------------------------------------+---------------------------------------
  Reporter:  tschaub                |       Owner:  tschaub    
      Type:  bug                    |      Status:  assigned   
  Priority:  minor                  |   Milestone:  2.6 Release
 Component:  Control.ModifyFeature  |     Version:  2.5        
Resolution:                         |    Keywords:             
     State:  Review                 |  
------------------------------------+---------------------------------------
Comment (by elemoine):

 Replying to [comment:1 tschaub]:
 > Occasionally, the drag feature control doesn't get notified of a feature
 out when we are resetting vertices (destroying radius handle in
 particular).  I would rather this be dealt with in the drag feature
 control, but I can't make it work there.  As an alternative, since we know
 (in resetVertices) we are destroying features that may be the same ones
 currently being handled by a drag handler, it seems reasonable to ensure
 that the drag handler is deactivated there (in the modify feature
 control).
 >
 > The attached patch fixes the issue and provides a test to prevent
 regression.
 >
 > Tests pass in FF.  Please review.

 I've started looking at this issue. I'm a bit chicken with having your
 patch applied because I feel it hides another problem (possibly in the
 feature handler) - why doesn't the drag feature control get notified on
 feature out? I'll look into it more seriously...

-- 
Ticket URL: <http://trac.openlayers.org/ticket/1235#comment:2>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list