[OpenLayers-Trac] [OpenLayers] #1235: ModifyFeature control has problems with its drag handler

[OpenLayers]

#1235: ModifyFeature control has problems with its drag handler
------------------------------------+---------------------------------------
  Reporter:  tschaub                |       Owner:  tschaub    
      Type:  bug                    |      Status:  assigned   
  Priority:  minor                  |   Milestone:  2.6 Release
 Component:  Control.ModifyFeature  |     Version:  2.5        
Resolution:                         |    Keywords:             
     State:  Review                 |  
------------------------------------+---------------------------------------
Comment (by tschaub):

 Replying to [comment:4 elemoine]:
 > Replying to [comment:3 tschaub]:
 > > Replying to [comment:2 elemoine]:
 > > > I've started looking at this issue. I'm a bit chicken with having
 your patch applied because I feel it hides another problem (possibly in
 the feature handler) - why doesn't the drag feature control get notified
 on feature out? I'll look into it more seriously...
 > >
 > > We destroy the radius handle when the drag completes (mouseup) - so
 there is no mousemove that can be translated in to a feature out.
 >
 > Ok. But still, I'm completely failing to understand the issue. The error
 occurs in the dragStart() method of the modify feature control. Why does
 dragStart() get called when unselecting the feature? That doesn't make
 sense to me. Your patch deactivates the drag handler so dragStart()
 doesn't get called and the error goes away. To me dragStart() shouldn't be
 called in the first place, even if the drag handler is still activated.
 >
 > I still feel we can fix this bug in a cleaner way.

 I agree.  That modify feature code haunts me.  I don't have the time now
 to get back in to it - but it seemed to make sense for a short while.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/1235#comment:5>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer