[OpenLayers-Trac] [OpenLayers] #24: Incorporate OpenLayers.Control.ScaleBar

OpenLayers trac at openlayers.org
Mon Jan 7 16:56:39 EST 2008


#24: Incorporate OpenLayers.Control.ScaleBar
----------------------------+-----------------------------------------------
  Reporter:  sderle         |       Owner:  tschaub    
      Type:  feature        |      Status:  assigned   
  Priority:  major          |   Milestone:  2.6 Release
 Component:  Control.Scale  |     Version:             
Resolution:                 |    Keywords:             
     State:  Review         |  
----------------------------+-----------------------------------------------
Comment (by ahocevar):

 Replying to [comment:21 tschaub]:
 > Good suggestions.  Thanks Andreas.  I'd actually like to move
 formatNumber entirely out of the control - but I think if it lives there
 for now, that's fine.  Also, I noticed a bug that had been sitting around
 in that styleValue method for years (see the "break rules" statement).
 Unless I'm losing my mind, we want to get out of there as soon as we find
 a rule that applies.  The whole point of going backwards through the
 stylesheets is to get to the applied rule first - then return.  I'm
 embarassed how long that was sitting uncorrected - unless I'm wrong about
 it now.

 To be honest, I do not see anything wrong here. To mee, it seems that it
 does exactly what you are describing.

 One more thing: the measure texts (around lines 320, 347 and 363) should
 also use formatNumber instead of toFixed to allow locale-dependant
 customization.

 And formatNumber would probably really be something for OpenLayers.Util.

-- 
Ticket URL: <http://trac.openlayers.org/ticket/24#comment:22>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer


More information about the Trac mailing list