[OpenLayers-Trac] [OpenLayers] #102: "loading..." indicator, so that users don't wonder what is happening
OpenLayers
trac at openlayers.org
Wed Jan 23 22:20:20 EST 2008
#102: "loading..." indicator, so that users don't wonder what is happening
-------------------------------+--------------------------------------------
Reporter: anonymous | Owner: sderle
Type: feature | Status: new
Priority: minor | Milestone: 2.6 Release
Component: Events | Version:
Resolution: | Keywords: patch
State: Needs Discussion |
-------------------------------+--------------------------------------------
Comment (by tschaub):
Some random comments:
1) We now use a simpler class syntax (no need for mentioning the
prototype or using inherit) - see any of the other OL classes for an
example.
2) Other elements associated with controls also use the
control.displayClass property as a class name. This is generated by the
Control superclass. I think it is better to use this convention than to
use the "loading" class name - it also gives app designers the ability to
override the name.
3) 200 and 300 look like magic values. Does this stop me from having a
partially opaque element over the whole map if my map is bigger than 200 x
300? I think these values are better as css declarations.
4) Super trivial, but we also now need to separate the @requires comment
block from other natural doc comments.
I also think this would make a nice addin. Would be good to start with
something anyway.
--
Ticket URL: <http://trac.openlayers.org/ticket/102#comment:12>
OpenLayers <http://openlayers.org/>
A free AJAX map viewer
More information about the Trac
mailing list